Fix integer overflow in composition time calculation#442
Open
Fix integer overflow in composition time calculation#442
Conversation
Use checked_add() instead of unchecked addition when calculating start_composition and end_composition times. Malformed MP4 files could trigger integer overflow, causing a panic in debug builds. The fix returns None when overflow is detected, allowing the error to propagate gracefully rather than crashing. Fixes Mozilla bug 2014838.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
checked_add()instead of unchecked addition when calculatingstart_compositionandend_compositiontimes. Malformed MP4 files could trigger integer overflow, causing a panic in debug builds, and (in practice in Firefox) UB bu wrap-around, and a demuxing error.The fix returns
Nonewhen overflow is detected, allowing the error to propagate gracefully rather than crashing in debug (but the end result in Firefox is the same).BMO#2014838.